netdev - Re: [PATCH v2] set fake_rtable's dst to NULL to avoid kernel Oops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1334742521.2472.102.camel@edumazet-glaptop>
Date:	Wed, 18 Apr 2012 11:48:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Peter Huang(Peng)" <peter.huangpeng@...wei.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	ctrix+debianbugs@...ynet.it, peter.huangpeng@...il.com,
	harry.majun@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] set fake_rtable's dst to NULL to avoid kernel Oops.

On Wed, 2012-04-18 at 17:34 +0800, Peter Huang(Peng) wrote:
> Add new flag DST_FAKE_RTABLE to dst_entry struct.
> 

Your changelog is not very helpful. Please add all the information you
provided in your previous mails. (stack trace and all)

> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Peter Huang <peter.huangpeng@...wei.com>
> ---
>   include/linux/netfilter_bridge.h |    8 ++++++++
>   include/net/dst.h                |    1 +
>   net/bridge/br_forward.c          |    1 +
>   net/bridge/br_netfilter.c        |    8 ++------
>   4 files changed, 12 insertions(+), 6 deletions(-)
> diff --git a/include/linux/netfilter_bridge.h 
> b/include/linux/netfilter_bridge.h
> index 0ddd161..eb09e3b 100644
> --- a/include/linux/netfilter_bridge.h
> +++ b/include/linux/netfilter_bridge.h
> @@ -104,9 +104,17 @@ struct bridge_skb_cb {
>          } daddr;
>   };
> 
> +static inline void br_drop_fake_rtable(struct sk_buff *skb) {
> +       struct dst_entry *dst = skb_dst(skb);
> +       /* abuse fact that only fake_rtable has DST_FAKE_RTABLE set */

You are kidding ? I said "Remove this comment, and leave an empty line"

> +       if (dst && (dst->flags & DST_FAKE_RTABLE))
> +               skb_dst_drop(skb);
> +}

Patch mangled, tabulations were replaced by spaces.

Please, please please read again Documentation/email-clients.txt, as I
already mentioned (privately)

Double check _everything_ before your next submission

This is the last time I even care

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html