netdev - RE: [PATCH] net/hyperv: RX packets may keep on increasing although the NIC is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16ED384958674747ACD81E6F1D403F4FE088@CDCEXMBX01.tw.trendnet.org>
Date:	Thu, 19 Apr 2012 00:45:39 +0000
From:	<wenqi_ma@...ndmicro.com.cn>
To:	<haiyangz@...rosoft.com>, <netdev@...r.kernel.org>
CC:	<davem@...emloft.net>, <kys@...rosoft.com>
Subject: RE: [PATCH] net/hyperv: RX packets may keep on increasing although
 the NIC is down

Thanks for your comments and suggestion, I will resubmit the revised patch later.

Best Regards,
Wenqi Ma

-----Original Message-----
From: Haiyang Zhang [mailto:haiyangz@...rosoft.com] 
Sent: Wednesday, April 18, 2012 10:20 PM
To: Wenqi Ma (RD-CN); netdev@...r.kernel.org
Cc: davem@...emloft.net; KY Srinivasan
Subject: RE: [PATCH] net/hyperv: RX packets may keep on increasing although the NIC is down



> -----Original Message-----
> From: Haiyang Zhang
> Sent: Wednesday, April 18, 2012 10:11 AM
> To: 'Wenqi Ma'; netdev@...r.kernel.org
> Cc: davem@...emloft.net; KY Srinivasan
> Subject: RE: [PATCH] net/hyperv: RX packets may keep on increasing
> although the NIC is down
> 
> 
> 
> > -----Original Message-----
> > From: Wenqi Ma [mailto:wenqi_ma@...ndmicro.com.cn]
> > Sent: Wednesday, April 18, 2012 10:02 AM
> > To: netdev@...r.kernel.org
> > Cc: davem@...emloft.net; Haiyang Zhang; Wenqi Ma
> > Subject: [PATCH] net/hyperv: RX packets may keep on increasing although
> > the NIC is down
> >
> > Although the network interface is down, the RX packets number which
> > could be observed by ifconfig may keep on increasing.
> >
> > This is because the WORK scheduled in netvsc_set_multicast_list()
> > may be executed after netvsc_close(). That means the rndis filter
> > may be re-enabled by do_set_multicast() even if it was closed by
> > netvsc_close().
> >
> > By canceling possible WORK before close the rndis filter, the issue
> > could be never happened.
> >
> > Signed-off-by: Wenqi Ma <wenqi_ma@...ndmicro.com.cn>
> > ---
> >  drivers/net/hyperv/netvsc_drv.c |   32 +++++++++++++-------------------
> >  1 files changed, 13 insertions(+), 19 deletions(-)
> 
> Thanks for patching it. I have some comments --
> The existing "struct set_multicast_work" is no longer in use, so it should be
> removed now.
> You should also add cancel_work into netvsc_change_mtu().

Also the patch subject should say what fixes/changes you made, not the bug behavior.
Recommend something like, "Adding cancellation to set promiscuous mode work".

Thanks,
- Haiyang


TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html