netdev - Re: [PATCH] NET: bcm63xx_enet: move phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334852238.5185.40.camel@sakura.staff.proxad.net>
Date:	Thu, 19 Apr 2012 18:17:18 +0200
From:	Maxime Bizon <mbizon@...ebox.fr>
To:	Jonas Gorski <jonas.gorski@...il.com>
Cc:	netdev@...r.kernel.org, Florian Fainelli <florian@...nwrt.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] NET: bcm63xx_enet: move phy_(dis)connect into
 probe/remove


On Thu, 2012-04-19 at 16:52 +0200, Jonas Gorski wrote:

> Yes, but none of the ethtool functions cause register writes in the
> priv->has_phy = true case when in PHY_READY or PHY_HALTED state. All
> they do is modify the phy_device's settings.

unless I'm mistaken:

phy_ethtool_sset() => phy_start_aneg()

will kick the state machine even when state is PHY_READY

-- 
Maxime


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html