netdev - Re: [PATCH] net: fix compile error of leaking kmemleak.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1334809328.2395.0.camel@edumazet-glaptop>
Date:	Thu, 19 Apr 2012 06:22:08 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shan Wei <shanwei88@...il.com>
Cc:	David Miller <davem@...emloft.net>, majianpeng@...il.com,
	NetDev <netdev@...r.kernel.org>,
	davidshan <davidshan@...cent.com>
Subject: Re: [PATCH] net: fix compile error of leaking kmemleak.h header

On Thu, 2012-04-19 at 12:05 +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@...cent.com>
> 
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
> 
> with same error in net/ipv4/route.c
> 
> Signed-off-by: Shan Wei <davidshan@...cent.com>
> ---
>  net/core/sysctl_net_core.c |    1 +
>  net/ipv4/route.c           |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index cee5991..247c69b 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -14,6 +14,7 @@
>  #include <linux/vmalloc.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> +#include <linux/kmemleak.h>
>  
>  #include <net/ip.h>
>  #include <net/sock.h>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index bcd4744..a1c115d 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -109,6 +109,7 @@
>  #include <net/rtnetlink.h>
>  #ifdef CONFIG_SYSCTL
>  #include <linux/sysctl.h>
> +#include <linux/kmemleak.h>
>  #endif
>  #include <net/secure_seq.h>
>  

yep, SLAB doesnt include it like SLUB

Acked-by: Eric Dumazet <eric.dumazet@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html