netdev - Re: [PATCH 1/2 v2] pch_gbe: Do not abort probe on bad MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120419184118.GA11880@kroah.com>
Date:	Thu, 19 Apr 2012 11:41:18 -0700
From:	Greg KH <greg@...ah.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	stable@...r.kernel.org, Darren Hart <dvhart@...ux.intel.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Jon Mason <jdmason@...zu.us>, netdev@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	David Laight <David.Laight@...LAB.COM>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 1/2 v2] pch_gbe: Do not abort probe on bad MAC

On Mon, Apr 02, 2012 at 12:00:44PM +0900, Tomoya MORINAGA wrote:
> If the MAC is invalid or not implemented, do not abort the probe. Issue
> a warning and prevent bringing the interface up until a MAC is set manually
> (via ifconfig $IFACE hw ether $MAC).
> 
> Tested on two platforms, one with a valid MAC, the other without a MAC. The real
> MAC is used if present, the interface fails to come up until the MAC is set on
> the other. They successfully get an IP over DHCP and pass a simple ping and
> login over ssh test.
> 
> This is meant to allow the Inforce SYS940X development board:
> http://www.inforcecomputing.com/SYS940X_ECX.html
> (and others suffering from a missing MAC) to work with the mainline kernel.
> Without this patch, the probe will fail and the interface will not be created,
> preventing the user from configuring the MAC manually.
> 
> This does not make any attempt to address a missing or invalid MAC for the
> pch_phub driver.
> 
> commit: 2b53d07891630dead46d65c8f896955fd3ae0302
> kernel version: 3.0, 3.2

How can you want this in 3.0, when the file this patches is not in the
3.0 kernel tree?

Please be more careful.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html