netdev - Re: [PATCH] net ax25: Reorder ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120419.153805.1416561328432806364.davem@davemloft.net>
Date:	Thu, 19 Apr 2012 15:38:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, ralf@...ux-mips.org,
	linux-hams@...r.kernel.org
Subject: Re: [PATCH] net ax25: Reorder ax25_exit to remove races.

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Wed, 18 Apr 2012 19:11:23 -0700

> While reviewing the sysctl code in ax25 I spotted races in ax25_exit
> where it is possible to receive notifications and packets after already
> freeing up some of the data structures needed to process those
> notifications and updates.
> 
> Call unregister_netdevice_notifier early so that the rest of the cleanup
> code does not need to deal with network devices.  This takes advantage
> of my recent enhancement to unregister_netdevice_notifier to send
> unregister notifications of all network devices that are current
> registered.
> 
> Move the unregistration for packet types, socket types and protocol
> types before we cleanup any of the ax25 data structures to remove the
> possibilities of other races.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Applied, thanks a lot Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html