lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 19 Apr 2012 16:58:47 +0800
From:	"Peter Huang(Peng)" <peter.huangpeng@...wei.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	ctrix+debianbugs@...ynet.it, Eric Dumazet <eric.dumazet@...il.com>,
	harry.majun@...wei.com, linux-kernel@...r.kernel.org,
	peter.huangpeng@...il.com
Subject: Re: [PATCH v3] set fake_rtable's dst to NULL to avoid kernel Oops.

On 2012/4/19 14:46, Stephen Hemminger wrote:
> On Thu, 19 Apr 2012 10:27:01 +0800
> "Peter Huang(Peng)"<peter.huangpeng@...wei.com>  wrote:
>
>> When bridge is deleted before tap/vif device's delete, kernel may
>> encounter an oops because of NULL reference to fake_rtable's dst.
>> Set fake_rtable's dst to NULL before sending packets out can solve this
>> problem.
>>
>> v3 enrich commit header
>>
>> v2 added a new flag DST_FAKE_RTABLE to dst_entry struct.
>>
>>
>> Acked-by: Eric Dumazet<eric.dumazet@...il.com>
>> Signed-off-by: Peter Huang<peter.huangpeng@...wei.com>
>
> I am okay with the contents of the patch but the formatting is all
> botched. It adds bad indentation and whitespace, please run it
> through checkpatch.

Got it, I will send the v4 version of modified format.
Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists