netdev - Question with secure_ipv4_port_ephemeral() implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201204202130.IJF95312.tQJFLMFOFSVHOO@I-love.SAKURA.ne.jp>
Date:	Fri, 20 Apr 2012 21:30:29 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	netdev@...r.kernel.org
Subject: Question with secure_ipv4_port_ephemeral() implementation

Commit 6e5714ea "net: Compute protocol sequence numbers and fragment IDs using
MD5." removed periodic get_random_bytes() calls. After that commit,

  static u32 net_secret[MD5_MESSAGE_BYTES / 4] ____cacheline_aligned;

is filled with random bytes for only once upon boot and is never updated again.
Then, shouldn't net_secret be marked as __read_mostly?

Just from curiosity... what was the reason for changing
secure_ipv4_port_ephemeral() generate same return value for same arguments?
Was periodically changing return value for same arguments unfriendly with NAT
or something?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html