netdev - Re: [PATCH 2/2] ks8851: Fix mutex deadlock in ks8851_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120421.153440.1754750876890229323.davem@davemloft.net>
Date:	Sat, 21 Apr 2012 15:34:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sboyd@...eaurora.org
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	tj@...nel.org, ben-linux@...ff.org
Subject: Re: [PATCH 2/2] ks8851: Fix mutex deadlock in ks8851_net_stop()

From: Stephen Boyd <sboyd@...eaurora.org>
Date: Wed, 18 Apr 2012 20:25:58 -0700

> There is a potential deadlock scenario when the ks8851 driver
> is removed. The interrupt handler schedules a workqueue which
> acquires a mutex that ks8851_net_stop() also acquires before
> flushing the workqueue. Previously lockdep wouldn't be able
> to find this problem but now that it has the support we can
> trigger this lockdep warning by rmmoding the driver after
> an ifconfig up.
> 
> Fix the possible deadlock by disabling the interrupts in 
> the chip and then release the lock across the workqueue
> flushing. The mutex is only there to proect the registers
> anyway so this should be ok.
 ...
> Cc: Ben Dooks <ben-linux@...ff.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html