netdev - Re: net_sched: gred: red_calc_qavg() called with current qavg for backlog?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120421.161032.2225288178918492428.davem@davemloft.net>
Date:	Sat, 21 Apr 2012 16:10:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	tgraf@...g.ch, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: net_sched: gred: red_calc_qavg() called with current qavg for
 backlog?

From: "Ward, David - 0663 - MITLL" <david.ward@...mit.edu>
Date: Sat, 21 Apr 2012 14:46:31 -0400

> In net/sched/sch_gred.c:
> 
> static int gred_dump(struct Qdisc *sch, struct sk_buff *skb)
> {
>      struct gred_sched *table = qdisc_priv(sch);
> ...
>      for (i = 0; i < MAX_DPs; i++) {
>          struct gred_sched_data *q = table->tab[i];
>          struct tc_gred_qopt opt;
> ...
>          opt.qave = red_calc_qavg(&q->parms, &q->vars, q->vars.qavg);
> 
> 
> I can't tell if red_calc_qavg is intentionally being passed the current 
> qavg as the backlog (which effectively causes qavg to only be 
> re-calculated if we are idling)?  Or should this be:
> 
>          opt.qave = red_calc_qavg(&q->parms,
>                                   &q->vars,
>                                   gred_backlog(table, q, sch));

Looking at commit 22b33429ab93155895854e9518a253680a920493
("[PKT_SCHED]: GRED: Use new generic red interface") it appears
that this line is intentional so that the dump reports the same
qave as it would have before Thomas's changes.

Thomas?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html