netdev - Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120423194339.GS5277@charybde.local>
Date:	Mon, 23 Apr 2012 21:43:39 +0200
From:	Stephane Fillod <fillods@...rs.sf.net>
To:	Paolo Pisati <paolo.pisati@...onical.com>
Cc:	Steve Glendinning <steve.glendinning@...well.net>,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY
 interrupt deal with carrier changes

lun, Apr 23, 2012, Paolo Pisati skribis:
> Without this patch sysfs reports the cable as present
> 
> flag@...g-desktop:~$ cat /sys/class/net/eth0/carrier
> 1
> 
> while it's not:
> 
> flag@...g-desktop:~$ sudo mii-tool eth0
> eth0: no link
> 
> Tested on my Beagle XM.
> 
> v2: added mantainer to the list of recipient

His e-mail address has changed, but somehow it has not been updated yet
in MAINTAINERS directory:  steve.glendinning () shawell.net

> Signed-off-by: Paolo Pisati <paolo.pisati@...onical.com>
> ---
>  drivers/net/usb/smsc95xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 3444514..93d3252 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,7 @@ static const struct driver_info smsc95xx_info = {
>  	.rx_fixup	= smsc95xx_rx_fixup,
>  	.tx_fixup	= smsc95xx_tx_fixup,
>  	.status		= smsc95xx_status,
> -	.flags		= FLAG_ETHER | FLAG_SEND_ZLP,
> +	.flags		= FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
>  };
>  
>  static const struct usb_device_id products[] = {

Tested this fix successfuly on elder brother smsc75xx, on top of
another patch yet-to-submit to fix smsc75xx's MDIO access.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html