lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Apr 2012 18:29:05 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Stuart Hodgson <smhodgson@...arflare.com> CC: <netdev@...r.kernel.org>, <bruce.w.allan@...el.com>, <decot@...gle.com>, <alexander.h.duyck@...el.com>, <davem@...emloft.net>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 2/3] Add capability to retrieve plug-in module EEPROM On Thu, 2012-04-19 at 16:39 +0100, Stuart Hodgson wrote: > Provides a new struct ethtool_modinfo that will return the > type and size of plug-in module eeprom (such as SFP+) for parsing > by userland program. > > The second provides the API to get the raw eeprom information > using the existing ethtool_eeprom structture to return the data > > Signed-off-by: Stuart Hodgson <smhodgson@...arflare.com> > --- > include/linux/ethtool.h | 33 +++++++++++++++++++++++++++++++++ > net/core/ethtool.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 80 insertions(+), 0 deletions(-) > > diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h > index 89d68d8..f6500f3 100644 > --- a/include/linux/ethtool.h > +++ b/include/linux/ethtool.h > @@ -137,6 +137,23 @@ struct ethtool_eeprom { > }; > > /** > + * struct ethtool_modinfo - plugin module eeprom information > + * @cmd: ETHTOOL_GMODULEINFO > + * @type: Standard the module information conforms to SFF_xxxx You renamed the type codes to begin with 'ETH_MODULE_SFF_', so this line needs to be updated too. > + * @eeprom_len: Length of the eeprom > + * > + * This structure is used to return the information to > + * properly size memory for a subsequent call to ETHTOOL_GMODULEEEPROM [...] The type code is also essential in order to parse the information. Also, a minor nitpick: you should put a '%' in front of the names of constants so they can be pretty-printed properly. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists