netdev - Re: [PATCH net-next] net: speedup skb_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120423.230205.418261556142199877.davem@davemloft.net>
Date:	Mon, 23 Apr 2012 23:02:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, axboe@...nel.dk
Subject: Re: [PATCH net-next] net: speedup skb_splice_bits()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 23 Apr 2012 00:26:16 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Commit 35f3d14db (pipe: add support for shrinking and growing pipes)
> added a slowdown for splice(socket -> pipe), as we might grow the spd
> used in skb_splice_bits() for each skb we process in splice() syscall.
> 
> Its not needed since skb lengths are capped. The default on-stack arrays
> are more than enough.
> 
> Use MAX_SKB_FRAGS instead of PIPE_DEF_BUFFERS to describe the reasonable
> limit per skb.
> 
> Add coalescing support to help splicing of GRO skbs built from linear
> skbs (linked into frag_list)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Tom Herbert <therbert@...gle.com>

Applied thanks.

I'm going to cleanup spd_fill_page() to return a bool.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html