netdev - Re: [PATCH 1/2] ss: fix the incorrect value of total UNIX_DIAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120425092645.180ac196@nehalam.linuxnetplumber.net>
Date:	Wed, 25 Apr 2012 09:26:45 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Shan Wei <shanwei88@...il.com>
Cc:	xemul@...allels.com, NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] ss: fix the incorrect value of total UNIX_DIAG_*
 number

On Wed, 25 Apr 2012 15:15:16 +0800
Shan Wei <shanwei88@...il.com> wrote:

> From: Shan Wei <davidshan@...cent.com>
> 
> UNIX_DIAG_MAX is included in enum type.
> It is equal to the total number of enum element.
> 
> But lots of enum MAX value is defined as the max enum element, e.g. INET_DIAG_MAX, XFRMA_MAX. 
> The right fixing way seems to define UNIX_DIAG_MAX as UNIX_DIAG_MEMINFO,
> but this way will break other user application.
> 
> So, just fix it on user application.

Nak, we should fix this in the kernel. It is ridiculous to have
a convention that is true for one route attribute type but not
for all of them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html