netdev - Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120425.194447.1519804940735129000.davem@davemloft.net>
Date:	Wed, 25 Apr 2012 19:44:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.walleij@...aro.org
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	gregkh@...uxfoundation.org, balbi@...com, jussi.kivilinna@...et.fi,
	haiyangz@...rosoft.com, yongjun_wei@...ndmicro.com.cn,
	ben@...adent.org.uk
Subject: Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h>
 defines

From: "Linus Walleij" <linus.walleij@...aro.org>
Date: Wed, 25 Apr 2012 17:30:08 +0200

> As a first step to consolidate the RNDIS implementations, break out
> a common file with all the #defines and move it to <linux/rndis.h>.
> The compilation screams about double-defines all over the place
> (as could be expected, this is why we're consolidating) but it
> compiles cleanly still.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

After this patch the build emits tons of warnings because you've
left a situation where there will be duplicate definitions:

In file included from drivers/net/hyperv/hyperv_net.h:30:0,
                 from drivers/net/hyperv/netvsc_drv.c:41:
include/linux/rndis.h:93:0: warning: "OID_GEN_CURRENT_PACKET_FILTER" redefined [enabled by default]
include/linux/rndis.h:51:0: note: this is the location of the previous definition
include/linux/rndis.h:239:0: warning: "RNDIS_STATUS_SUCCESS" redefined [enabled by default]
 ...

This is unacceptable, the tree must build cleanly and work properly at
each step in the patch series, in order to ensure bisectability.  You
can't "fix it up" in a patch later in the series and just assume that
the whole series is applied.

Also, in the new file you created you added a spurious empty line at
the end of the file.  Please remove that as GIT notices this when
applying your patch and thus warns about it.

In fact, please go through this entire patch set (like I was) making
sure the build is clean and no bugs or bisectability issues are
introduced each step of the way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html