netdev - RE: [PATCH] tcp repair: Fix unaligned access when repairing options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2012 15:11:30 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Pavel Emelyanov" <xemul@...allels.com>,
	"David Miller" <davem@...emloft.net>,
	"Linux Netdev List" <netdev@...r.kernel.org>
Subject: RE: [PATCH] tcp repair: Fix unaligned access when repairing options

 
> +struct tcp_repair_opt {
> +	__u8	opt_code;
> +	__u16	opt_val;
> +};

That structure has an implied pad field, probably best to
either make it explicit or change the types.

I'd have thought it would do no harm to use two __u32 fields
(unless you really need to save memory somewhere).

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html