netdev - Re: [PATCH] dl2k: Clean up rio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120426.053859.370303075509597686.davem@davemloft.net>
Date:	Thu, 26 Apr 2012 05:38:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffm@...e.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] dl2k: Clean up rio_ioctl

From: Jeff Mahoney <jeffm@...e.com>
Date: Wed, 25 Apr 2012 20:32:09 -0400

> The dl2k driver's rio_ioctl call has a few issues:
> - No permissions checking
> - Implements SIOCGMIIREG and SIOCGMIIREG using the SIOCDEVPRIVATE numbers
> - Has a few ioctls that may have been used for debugging at one point
>   but have no place in the kernel proper.
> 
> This patch removes all but the MII ioctls, renumbers them to use the
> standard ones, and adds the proper permission check for SIOCSMIIREG.
> 
> We can also get rid of the dl2k-specific struct mii_data in favor of
> the generic struct mii_ioctl_data.
> 
> Since we have the phyid on hand, we can add the SIOCGMIIPHY ioctl too.
> 
> Most of the MII code for the driver could probably be converted to use
> the generic MII library but I don't have a device to test the results.
> 
> Reported-by: Stephan Mueller <stephan.mueller@...ec.com>
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html