netdev - Re: [PATCH net-next] ipv6: RTAX_FEATURE_ALLFRAG causes inefficient TCP segment sizing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e135d034e75f56cb6d5318595c17023@greed.fud.no>
Date:	Thu, 26 Apr 2012 12:32:17 +0200
From:	Tore Anderson <tore@....no>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Maciej Żenczykowski <maze@...gle.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH net-next] ipv6: RTAX_FEATURE_ALLFRAG causes inefficient TCP segment sizing

* Eric Dumazet

> Yes, in fact we are going to keep the allfrag feature, and arm it if 
> we
> receive an mtu < 512.

One thing to think about if you go down this path is to keep track of 
the PMTU received in the ICMPv6 PTB. If you activate the allfrag feature 
on a destination because you received a PTB with PMTU=400, it's not 
useful to include the Fragmentation header in packets <400 bytes in 
size, for example.

With the current code, even tiny packets without any L4 payload (e.g. 
TCP SYN/ACK) will have the Fragmentation header added. That's not 
optimal, but necessary since the current code does not keep track of the 
actual PMTU if it is <1280 as far as I can tell (instead it discards the 
received PMTU value, clamps the effective PMTU to 1280, and enables 
allfrag).

Tore
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html