netdev - RE: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2012 13:00:54 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	David Miller <davem@...emloft.net>
CC:	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"balbi@...com" <balbi@...com>,
	"jussi.kivilinna@...et.fi" <jussi.kivilinna@...et.fi>,
	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>
Subject: RE: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h>
 defines

________________________________________
> From: David Miller [davem@...emloft.net]
> Sent: Wednesday, April 25, 2012 7:45 PM
> To: Haiyang Zhang
> Cc: linus.walleij@...aro.org; netdev@...r.kernel.org; linux-usb@...r.kernel.org; gregkh@...uxfoundation.org; balbi@...com; jussi.kivilinna@...et.fi; yongjun_wei@...ndmicro.com.cn; ben@...adent.org.uk
> Subject: Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines
> 
> From: Haiyang Zhang <haiyangz@...rosoft.com>
> Date: Wed, 25 Apr 2012 20:38:31 +0000
> 
> > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> I don't think you really thoroughly reviewed this patch, otherwise
> you would have noticed the duplicate definitions that result from
> this patch which adds hundreds of warnings to the build.

Actually, I did see the duplicate defines, I also noticed the author pointing out
-- "The compilation screams about double-defines all over the place." In my
test, the warnings go away after all patches applied.

But, thanks for your comments. I believe the author has now realized that
consolidating the defines and removing the duplicates should be done in one
patch so that there are no warnings.

Thanks,
- Haiyang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html