netdev - Re: [PATCH net-next] net: cleanups in sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1335506540.2775.75.camel@edumazet-glaptop>
Date:	Fri, 27 Apr 2012 08:02:20 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: cleanups in sock_setsockopt()

On Fri, 2012-04-27 at 01:48 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 27 Apr 2012 07:41:59 +0200
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Use min()/max() macros, reformat two comments, use !!test_bit() to
> > match !!sock_flag()
> > 
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> Introduces warnings:
> 
> net/core/sock.c: In function ‘sock_setsockopt’:
> net/core/sock.c:584:9: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> net/core/sock.c:605:9: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> net/core/sock.c:623:19: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> 
> and that makes sense since int is signed and __u32 is not.
> 
> Your compiler didn't spit that out too?

Hmm... I wonder how I missed these...

I'll fix this, thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html