| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120428143022.GA5944@hmsreliant.think-freely.org> Date: Sat, 28 Apr 2012 10:30:22 -0400 From: Neil Horman <nhorman@...driver.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH v2 1/2] drop_monitor: fix sleeping in invalid context warning On Sat, Apr 28, 2012 at 08:11:13AM +0200, Eric Dumazet wrote: > On Fri, 2012-04-27 at 16:11 -0400, Neil Horman wrote: > > Eric Dumazet pointed out this warning in the drop_monitor protocol to me: > > > > > It stems from holding a spinlock (trace_state_lock) while attempting to register > > or unregister tracepoint hooks, making in_atomic() true in this context, leading > > to the warning when the tracepoint calls might_sleep() while its taking a mutex. > > Since we only use the trace_state_lock to prevent trace protocol state races, as > > well as hardware stat list updates on an rcu write side, we can just convert the > > spinlock to a mutex to avoid this problem. > > > > Signed-off-by: Neil Horman <nhorman@...driver.com> > > Reported-by: Eric Dumazet <eric.dumazet@...il.com> > > CC: David Miller <davem@...emloft.net> > > --- > > Acked-by: Eric Dumazet <edumazet@...gle.com> > > Thanks Neil > Anytmie, thanks for reporting it. Neil > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists