netdev - Re: [PATCH net-next] pch_gbe: reprogram multicast address register on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120428164133.GB2165@netboy.at.omicron.at>
Date:	Sat, 28 Apr 2012 18:41:34 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, tshimizu818@...il.com
Subject: Re: [PATCH net-next] pch_gbe: reprogram multicast address register
 on reset

On Sat, Apr 28, 2012 at 01:53:41PM +0800, roy.qing.li@...il.com wrote:
> From: RongQing.Li <roy.qing.li@...il.com>
> 
> The reset logic after a Rx FIFO overrun will clear the programmed
> multicast addresses. This patch fixes the issue by reprogramming the
> registers after the reset.
> 
> The commit eefc48b tried to fix this problem, but it introduces
> unnecessary codes. In fact, all multicast addresses have been saved
> in netdev->mc, So we can call pch_gbe_set_multi() directly after
> reset_hw and reset_rx.
> 
> This commit kills 50+ line codes

Looks good to me.

Acked-by: Richard Cochran <richardcochran@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html