netdev - Re: [PATCH] net: smsc75xx: fix MDIO access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120428.215536.1073848205954371267.davem@davemloft.net>
Date:	Sat, 28 Apr 2012 21:55:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fillods@...rs.sf.net
Cc:	netdev@...r.kernel.org, steve.glendinning@...well.net
Subject: Re: [PATCH] net: smsc75xx: fix MDIO access

From: Stephane Fillod <fillods@...rs.sf.net>
Date: Thu, 26 Apr 2012 21:55:17 +0200

> * make MDIO read/write to work, the MII_ACCESS_BUSY bit was missing
>   to actually trigger the I/O. Rem: the smsc75xx is different from
>   the smsc95xx in that regard.
> * fix PHY interrupt acknowledge, which needs a mdio_write
>   to clear PHY_INT_SRC instead of a usual read like in smsc95xx.
> * fix bug in phy_init loop that was ignoring BMCR reset bit,
>   akin to smsc95xx's d946092000698fd204d82a9d239103c656fb63bf
> * mark link down on startup and let PHY interrupt deal with carrier
>   changes, akin to 07d69d4238418746a7b85c5d05ec17c658a2a390
> * declare the smsc75xx's MII as GMII capable
> 
> Tested on ARM/Omap3 with LAN7500-CEB.
> 
> Signed-off-by: Stephane Fillod <fillods@...rs.sf.net>
> Cc: Steve Glendinning <steve.glendinning@...well.net>

Steve, could you give this a quick review?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html