netdev - Re: bridge: Fix fatal typo in setup of multicast_querier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120430.132738.647233864900000159.davem@davemloft.net>
Date:	Mon, 30 Apr 2012 13:27:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.hengli.com.au
Cc:	netdev@...r.kernel.org
Subject: Re: bridge: Fix fatal typo in setup of multicast_querier_expired

From: Herbert Xu <herbert@...dor.hengli.com.au>
Date: Mon, 30 Apr 2012 20:22:56 +1000

> Unfortunately it seems that I didn't properly test the case of
> an expired external querier in the recent multicast bridge series.
> 
> The setup of the timer in that case is completely broken and leads
> to a NULL-pointer dereference.  This patch fixes it.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
 ...
> -		    br_multicast_querier_expired, 0);
> +		    br_multicast_querier_expired, (unsigned long)br);
>  	setup_timer(&br->multicast_query_timer, br_multicast_query_expired,
>  		    (unsigned long)br);
>  }
> 
> Sorry for the screw-up.

Please do not put comments after the patch, this made the second hunk
reject when I pulled it out of patchwork.

Anyways, fixed up and applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html