netdev - Re: inconsistent lock/deadlock crash, vanilla 3.3.4, 32bit, tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120430.133834.1047789597359787120.davem@davemloft.net>
Date:	Mon, 30 Apr 2012 13:38:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	denys@...p.net.lb, netdev@...r.kernel.org, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	linux-kernel@...r.kernel.org, glommer@...allels.com
Subject: Re: inconsistent lock/deadlock crash, vanilla 3.3.4, 32bit, tcp

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 29 Apr 2012 11:21:56 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> [PATCH] net: fix sk_sockets_allocated_read_positive
> 
> Denys Fedoryshchenko reported frequent crashes on a proxy server and kindly
> provided a lockdep report that explains it all :
 ...
> Bug is that sk_sockets_allocated_read_positive() calls
> percpu_counter_sum_positive() without BH being disabled.
> 
> This bug was added in commit 180d8cd942ce33
> (foundations of per-cgroup memory pressure controlling.), since previous
> code was using percpu_counter_read_positive() which is IRQ safe.
> 
> In __sk_mem_schedule() we dont need the precise count of allocated
> sockets and can revert to previous behavior.
> 
> Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Sined-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html