netdev - Re: [PATCH v2] tcp: fix infinite cwnd in tcp_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120430.134540.610433288172120407.davem@davemloft.net>
Date:	Mon, 30 Apr 2012 13:45:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	ycheng@...gle.com, ilpo.jarvinen@...sinki.fi, nanditad@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] tcp: fix infinite cwnd in tcp_complete_cwr()

From: Neal Cardwell <ncardwell@...gle.com>
Date: Mon, 30 Apr 2012 12:25:56 -0400

> On Mon, Apr 30, 2012 at 12:00 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
>> When the cwnd reduction is done, ssthresh may be infinite
>> if TCP enters CWR via ECN or F-RTO. If cwnd is not undone, i.e.,
>> undo_marker is set, tcp_complete_cwr() falsely set cwnd to the
>> infinite ssthresh value. The correct operation is to keep cwnd
>> intact because it has been updated in ECN or F-RTO.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
>> ---
>> ChangeLog since v1:
>>  - Add snd_cwnd_stamp timestamping in CWR mode
>>
>>  net/ipv4/tcp_input.c |    9 ++++++---
>>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html