lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <A1F3067C9B68744AA19F6802BAB8FFDC0DD3CAAA@TK5EX14MBXC221.redmond.corp.microsoft.com> Date: Tue, 1 May 2012 18:54:54 +0000 From: Haiyang Zhang <haiyangz@...rosoft.com> To: Linus Walleij <linus.walleij@...aro.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "David S. Miller" <davem@...emloft.net>, Felipe Balbi <balbi@...com> CC: Jussi Kivilinna <jussi.kivilinna@...et.fi>, Wei Yongjun <yongjun_wei@...ndmicro.com.cn>, Ben Hutchings <ben@...adent.org.uk> Subject: RE: [PATCH 02/13 v4] usb/net: rndis: break out <linux/rndis.h> defines > -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@...aro.org] > Sent: Tuesday, May 01, 2012 2:22 PM > To: netdev@...r.kernel.org; linux-usb@...r.kernel.org; Greg Kroah-Hartman; > David S. Miller; Felipe Balbi > Cc: Jussi Kivilinna; Haiyang Zhang; Wei Yongjun; Ben Hutchings; Linus > Walleij > Subject: [PATCH 02/13 v4] usb/net: rndis: break out <linux/rndis.h> > defines > > As a first step to consolidate the RNDIS implementations, break out > a common file with all the #defines and move it to <linux/rndis.h>. > The compilation screams about double-defines all over the place > (as could be expected, this is why we're consolidating) but it > compiles cleanly still. > > This also deletes the immediate duplicated defines in the > <linux/rndis.h> file that yields a lot of compilation warnings. > > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org> > --- > ChangeLog v2->v3: > - Squashed subsequent patch removing duplicate entries into > this patch so it's bisectable without any compilation warnings. I have not reviewed this version yet. Also, I think you should merge the "ChangeLog v2->v3" into the patch comments. Don't need to say "The compilation screams about double-defines all over the place" any more. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists