netdev - Re: [PATCH] cxgb3: Don't call cxgb_vlan_mode until q locks are initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120430.220939.1458086000301177724.davem@davemloft.net>
Date:	Mon, 30 Apr 2012 22:09:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roland@...nel.org
Cc:	divy@...lsio.com, netdev@...r.kernel.org, roland@...estorage.com
Subject: Re: [PATCH] cxgb3: Don't call cxgb_vlan_mode until q locks are
 initialized

From: Roland Dreier <roland@...nel.org>
Date: Mon, 30 Apr 2012 10:15:47 -0700

> From: Roland Dreier <roland@...estorage.com>
> 
> The driver calls cxgb_vlan_mode() from init_one().  This calls into
> synchronize_rx(), which locks all the q locks, but the q locks are not
> initialized until cxgb_up() -> setup_sge_qsets().  So move the call to
> cxgb_vlan_mode() into cxgb_up(), after the call to setup_sge_qsets().
> We also move the body of these functions up higher to avoid having to
> a forward declaration.
> 
> This was found because of the lockdep warning:
 ...
> Contrary to what lockdep says, the code is not fine: we are locking an
> uninitialized spinlock.
> 
> Signed-off-by: Roland Dreier <roland@...estorage.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html