netdev - Re: [PATCH net-next] bnx2x: remove some bloat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1335855463.12363.16.camel@lb-tlvb-eilong.il.broadcom.com>
Date:	Tue, 1 May 2012 09:57:43 +0300
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>
cc:	"David Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"Neal Cardwell" <ncardwell@...gle.com>,
	"Tom Herbert" <therbert@...gle.com>,
	"Maciej Żenczykowski" <maze@...gle.com>,
	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>,
	"Ben Hutchings" <bhutchings@...arflare.com>,
	"Matt Carlson" <mcarlson@...adcom.com>,
	"Michael Chan" <mchan@...adcom.com>,
	"Herbert Xu" <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next] bnx2x: remove some bloat

On Sat, 2012-04-28 at 09:39 +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> Before doing skb->head_frag work on bnx2x driver, I found too much stuff
> was inlined in bnx2x/bnx2x_cmn.h for no good reason and made my work not
> very easy.
> 
> Move some big functions out of this include file to the respective .c
> file.
> 
> A lot of inline keywords are not needed at all in this huge driver.
> 
>    text	   data	    bss	    dec	    hex	filename
>  490083	   1270	     56	 491409	  77f91	bnx2x/bnx2x.ko.before
>  484206	   1270	     56	 485532	  7689c	bnx2x/bnx2x.ko
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Eilon Greenstein <eilong@...adcom.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Cc: Tom Herbert <therbert@...gle.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> Cc: Matt Carlson <mcarlson@...adcom.com>
> Cc: Michael Chan <mchan@...adcom.com>

Acked-by: Eilon Greenstein <eilong@...adcom.com>

Thanks Eric - it makes sense.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html