lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120501.100241.1409452912879198250.davem@davemloft.net> Date: Tue, 01 May 2012 10:02:41 -0400 (EDT) From: David Miller <davem@...emloft.net> To: jeffrey.t.kirsher@...el.com Cc: donald.c.skidmore@...el.com, netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com, bhutchings@...arflare.com Subject: Re: [net-next v2 6/8] ixgbe: add syfs interface for to export read only driver information From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Date: Tue, 1 May 2012 01:51:07 -0700 > From: Don Skidmore <donald.c.skidmore@...el.com> > > This patch exports non-thermal (which was done via hwmon in an earlier > patch) data to sysfs which isn't readily available elsewhere. All of the > fields are read only as this interface is to only export driver data. > > Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com> > Tested-by: Stephen Ko <stephen.s.ko@...el.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> I don't like it. Some of this stuff is generic and belongs somewhere like ethtool, for example the descriptor sizes and queue sizes. The others are reading registers, and we have an ethtool API for that already. But putting anything like this in sysfs is pointless, because the stuff that other cards have too will then go into differently named sysfs files which, as is oft repeated here, is a terrible user experience. If you want to do this right, add a new ethtool interface that allows the publication of card specific unchanging values, in a style like what we already do for statistics. Have one query that gets the string list, and then another which fetches the actual values. I hate sysfs, don't send me any more patches that add sysfs files for networking devices. :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists