netdev - Re: [PATCH] net/niu: remove one superfluous dma mask check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120503.145541.1415935370418437633.davem@davemloft.net>
Date:	Thu, 03 May 2012 14:55:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bigeasy@...utronix.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/niu: remove one superfluous dma mask check

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Thu,  3 May 2012 20:22:00 +0200

> The idea here seems to be to get a 44bit DMA mask working and if this
> fails it should fallback to a 32bit DMA mask. The dma_mask variable is
> assigned once to 44bit and never updated. pci_set_dma_mask() and
> pci_set_consistent_dma_mask() are both implemented as functions so there
> is no evil macro which might update dma_mask. Looking at the assembly, I
> see a call to dma_set_mask() followed by dma_supported() and then a jump
> passed the second dma_set_mask(). The only way to get to second
> dma_set_mask() call is by an error code in the first one.
> 
> So I hereby remove the check since it looks superfluous. Please ignore
> the path if there is black magic involved.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

It looks like it's been this way since day one. :-)

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html