netdev - Re: [PATCH v2] net: l2tp: unlock socket lock before returning from l2tp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120502.210509.1240046301942391500.davem@davemloft.net>
Date:	Wed, 02 May 2012 21:05:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	levinsasha928@...il.com, jchapman@...alix.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	davej@...hat.com
Subject: Re: [PATCH v2] net: l2tp: unlock socket lock before returning from
 l2tp_ip_sendmsg

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 May 2012 16:32:36 +0200

> On Wed, 2012-05-02 at 15:58 +0200, Sasha Levin wrote:
>> l2tp_ip_sendmsg could return without releasing socket lock, making it all the
>> way to userspace, and generating the following warning:
>> 
>> [  130.891594] ================================================
>> [  130.894569] [ BUG: lock held when returning to user space! ]
>> [  130.897257] 3.4.0-rc5-next-20120501-sasha #104 Tainted: G        W
>> [  130.900336] ------------------------------------------------
>> [  130.902996] trinity/8384 is leaving the kernel with locks still held!
>> [  130.906106] 1 lock held by trinity/8384:
>> [  130.907924]  #0:  (sk_lock-AF_INET){+.+.+.}, at: [<ffffffff82b9503f>] l2tp_ip_sendmsg+0x2f/0x550
>> 
>> Introduced by commit 2f16270 ("l2tp: Fix locking in l2tp_ip.c").
>> 
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Sasha Levin <levinsasha928@...il.com>
>> ---
> 
> Oh well, please read Documentation/stable_kernel_rules.txt
> 
> Also, David prefers to handle stable submissions himself for net tree.
> 
> Anyway :
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html