netdev - Re: [PATCH v2 net-next] net: take care of cloned skbs in tcp_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120502.211147.1622167790503932925.davem@davemloft.net>
Date:	Wed, 02 May 2012 21:11:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	alexander.h.duyck@...el.com, alexander.duyck@...il.com,
	netdev@...r.kernel.org, ncardwell@...gle.com, therbert@...gle.com,
	jeffrey.t.kirsher@...el.com, mchan@...adcom.com,
	mcarlson@...adcom.com, herbert@...dor.hengli.com.au,
	bhutchings@...arflare.com, ilpo.jarvinen@...sinki.fi,
	maze@...gle.com
Subject: Re: [PATCH v2 net-next] net: take care of cloned skbs in
 tcp_try_coalesce()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 May 2012 19:55:58 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Before stealing fragments or skb head, we must make sure skbs are not
> cloned.
> 
> Alexander was worried about destination skb being cloned : In bridge
> setups, a driver could be fooled if skb->data_len would not match skb
> nr_frags.
> 
> If source skb is cloned, we must take references on pages instead.
> 
> Bug happened using tcpdump (if not using mmap())
> 
> Introduce kfree_skb_partial() helper to cleanup code.
> 
> Reported-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html