netdev - [v2 PATCH 0/4] Cleanup tcp_try_coalesce, fix module lockup on ixgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120503071141.13636.37564.stgit@gitlad.jf.intel.com>
Date:	Thu, 03 May 2012 00:18:54 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net, jeffrey.t.kirsher@...el.com,
	edumazet@...gle.com
Subject: [v2 PATCH 0/4] Cleanup tcp_try_coalesce, fix module lockup on ixgbe

This set represents the original patch I had done for trying to cleanup
tcp_try_coalesce broken into 3 patches.  The first one illustrates how I
believe we should be updating the truesize based on either the size of
sk_buff in the case of head reuse, or sk_buff plus the size of the head in
the case of a headlen of 0.

The other two patches go through and reorder things so there isn't as much
need for gotos.  I believe it makes the code much more readable since it
starts at the top and finishes at the bottom instead of looping through the
entire code path a few times.

The last patch addresses an issue I ran into on ixgbe.  It turns out the
recent HWMON patch added a but on 82598 adapters that caused the driver to
get hung in module unload.  I figured I would submit it directly since it
is a small change to fix an issue that could have a larger impact.

On that note I am going to sleep now and will respond to any reviews and/or
comments in the morning.

---

Alexander Duyck (4):
      ixgbe: Fix use after free on module remove
      tcp: move stats merge to the end of tcp_try_coalesce
      tcp: Move code related to head frag in tcp_try_coalesce
      tcp: Fix truesize accounting in tcp_try_coalesce

 drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |    4 +
 net/ipv4/tcp_input.c                           |   83 +++++++++++++-----------
 2 files changed, 49 insertions(+), 38 deletions(-)

-- 

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html