lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1336124554.1766.11.camel@joe2Laptop> Date: Fri, 04 May 2012 02:42:34 -0700 From: Joe Perches <joe@...ches.com> To: Arend van Spriel <arend@...adcom.com> Cc: David Miller <davem@...emloft.net>, linville@...driver.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: pull request: wireless-next 2012-05-03 On Fri, 2012-05-04 at 10:57 +0200, Arend van Spriel wrote: > On 05/03/2012 07:29 PM, Joe Perches wrote: > > On Thu, 2012-05-03 at 13:17 -0400, David Miller wrote: > >> ... > >> - if (hdev->discovery.type == DISCOV_TYPE_INTERLEAVED) { > >> + if (hdev->discovery.type == DISCOV_TYPE_INTERLEAVED && > >> + hdev->discovery.state == DISCOVERY_FINDING) { > >> > >> Really, we went through this a million times very recently and I'm > >> not pulling anything into my tree that has garbage like this in it. > > > > Perhaps the bluetooth folk can adopt using > > > > scripts/checkpatch.pl --strict > > > > or maybe checkpatch could be changed to use > > --strict on patches in net and drivers/net > > automatically. > > When the --strict option was added it --strict was added to checkpatch in 2007 to quiet some of the more controversial output messages. > So why not do --strict by default and get rid of the option flag. Some subsystem maintainers would again complain about checkpatch output verbosity. Maybe some of the less controversial CHK tests can be changed to WARN. Still, who really cares whether or not multiline indentation is aligned after an open parenthesis or on a tabstop? Ted Ts'o had an idea awhile back about adding .checkpatch config files to every directory that had specific formatting wants. That might work too. https://lkml.org/lkml/2012/3/13/662 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists