lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120504121545.GA32665@midget.suse.cz> Date: Fri, 4 May 2012 14:15:45 +0200 From: Jiri Bohac <jbohac@...e.cz> To: Jay Vosburgh <fubar@...ibm.com> Cc: Jiri Bohac <jbohac@...e.cz>, Eric Dumazet <eric.dumazet@...il.com>, Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org Subject: Re: bonding: don't increase rx_dropped after processing LACPDUs On Wed, May 02, 2012 at 04:10:39PM -0700, Jay Vosburgh wrote: > Won't this make it impossible to bind a PF_PACKET socket to > sll_protocol == ETH_P_SLOW and see the LACPDUs, but only when bonding is > running 802.3ad? yes it will... > This because the ptype_all check in > __netif_receive_skb happens before the rx_handler, but the ptype_base > check (bound packet socket, for example) happens after. Currently, > libpcap looks to bind to ETH_P_ALL, so it won't be affected. Does it make any sense for the packet socket not to bind to ETH_P_ALL? With all the rx_handlers interfering with the packet (e.g. modifying skb->dev, modifying the MAC address), binding to ETH_P_SLOW will never reliably get you the the original frame with reliable information about the incoming device. > If so, is that something we care about? I think not. -- Jiri Bohac <jbohac@...e.cz> SUSE Labs, SUSE CZ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists