netdev - Re: [PATCHv3 6/6] mISDN: Help to identify the card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLpKjFHx7b3oTjz7a8wvxQmPME-sK147n8CX6y8+Pii2rg@mail.gmail.com>
Date:	Fri, 4 May 2012 10:48:26 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Karsten Keil <kkeil@...ux-pingi.de>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Karsten Keil <isdn@...ux-pingi.de>
Subject: Re: [PATCHv3 6/6] mISDN: Help to identify the card

On Fri, May 4, 2012 at 10:15 AM, Karsten Keil <kkeil@...ux-pingi.de> wrote:
> From: Karsten Keil <isdn@...ux-pingi.de>
>
> With multiple cards is hard to figure out which port caused trouble
> int the layer2 routines (e.g. got a timeout).
> Now we have the informations in the log output.

If you are in here changing all these printk(KERN_LEVEL ...) lines anyway,
then perhaps it is a good time to make use of pr_warn() and friends to
help avoid some multi-line fragmentation things like this:

>                                printk(KERN_WARNING
>                                       "%s: windowar[%d] is NULL\n",
> -                                      __func__, p1);
> +                                      mISDNDevName4ch(&l2->ch), p1);
>                        l2->windowar[p1] = NULL;

Paul.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html