lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 May 2012 14:48:49 +0800 From: Deng-Cheng Zhu <dczhu@...s.com> To: Tom Herbert <therbert@...gle.com> CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <eric.dumazet@...il.com> Subject: Re: [PATCH v2] RPS: Sparse connection optimizations - v2 On 05/04/2012 11:31 PM, Tom Herbert wrote: >> I think the mechanisms of rps_dev_flow_table and cpu_flow (in this >> patch) are different: The former works along with rps_sock_flow_table >> whose CPU info is based on recvmsg by the application. But for the tests >> like what I did, there's no application involved. >> > While rps_sock_flow_table is currently only managed by recvmsg, it > still is the general mechanism that maps flows to CPUs for steering. > There should be nothing preventing you from populating and managing > entries in other ways. Well, even using rps_sock_flow_table to map the sparse flows to CPUs, we still need a data structure to describe a single flow -- that's what struct cpu_flow is doing. Besides, rps_sock_flow_table, by its meaning, does not seem to make sense for our purpose. How about keeping the patch as is but renaming struct cpu_flow to struct rps_sparse_flow? It's like: --------------------------------------------- In include/linux/netdevice.h: struct rps_sparse_flow { struct net_device *dev; u32 rxhash; unsigned long ts; }; In net/core/dev.c: static DEFINE_PER_CPU(struct rps_sparse_flow [CONFIG_NR_RPS_MAP_LOOPS], rps_sparse_flow_table); --------------------------------------------- The above looks similar to rps_dev_flow/rps_dev_flow_table, and we do not necessarily go with rps_sock_flow_table. Thanks, Deng-Cheng -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists