netdev - Re: batostr() function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA37ikbcPQ5UwX4Yfx9cg-J7uSFoEJmxv8fkn7Hj3b_=pUutMw@mail.gmail.com>
Date:	Tue, 8 May 2012 11:20:37 -0300
From:	Ulisses Furquim <ulisses@...fusion.mobi>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-bluetooth@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: batostr() function

Hi David,

On Tue, May 8, 2012 at 10:30 AM, David Herrmann
<dh.herrmann@...glemail.com> wrote:
>
> Hi Johannes
>
> On Mon, May 7, 2012 at 1:49 PM, Johannes Berg <johannes@...solutions.net>
> wrote:
> > Really? 2 static buffers that are used alternately based on a static
> > variable? How can that possibly be thread-safe? That may work in very
> > restricted scenarios, but ...
>
> Looking at "git blame" it seems the whole function is still from
> linux-2.4. Looks like no-one ever noticed. I've sent a patchset fixing
> it, thanks.

Thanks for fixing it. I'm sure we haven't noticed but it's still weird
to have it this way. :-/

Regards,

--
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html