netdev - Re: [PATCH 3.3.0] phy:icplus:fix Auto Power Saving in ip101a_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 May 2012 11:57:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jrnieder@...il.com
Cc:	srinivas.kandagatla@...com, netdev@...r.kernel.org,
	peppe.cavallaro@...com
Subject: Re: [PATCH 3.3.0] phy:icplus:fix Auto Power Saving in
 ip101a_config_init.

From: Jonathan Nieder <jrnieder@...il.com>
Date: Wed, 9 May 2012 02:25:37 -0500

> Hi Dave,
> 
> David Miller wrote:
>> From: Srinivas KANDAGATLA <srinivas.kandagatla@...com>
> 
>>> This patch fixes Auto Power Saving configuration in ip101a_config_init
>>> which was broken as there is no phy register write followed after
>>> setting IP101A_APS_ON flag.
>>>
>>> This patch also fixes the return value of ip101a_config_init.
>>>
>>> Without this patch ip101a_config_init returns 2 which is not an error
>>> accroding to IS_ERR and the mac driver will continue accessing 2 as
>>> valid pointer to phy_dev resulting in memory fault.
>>>
>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...com>
>>
>> Applied and queued up for -stable, thanks.
> 
> I'm guessing 3.2.y needs this, too, since it also includes
> v3.2-rc1~129^2~247 ("net/phy: add IC+ IP101A and support APS").
> 
> Here's a quick backport made by adjusting the context line to
> use IP101A_APS_ON instead of IP101A_G_APS_ON.
> 
> Please include it in some later stable update if appropriate.

Please submit this directly to the stable list.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html