netdev - RE: [net-next 2/8] e1000e: initial support for i217

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 May 2012 16:25:00 +0000
From:	"Allan, Bruce W" <bruce.w.allan@...el.com>
To:	Bjørn Mork <bjorn@...k.no>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 2/8] e1000e: initial support for i217

> -----Original Message-----
> From: Bjørn Mork [mailto:bjorn@...k.no]
> Sent: Saturday, May 05, 2012 1:02 AM
> To: Kirsher, Jeffrey T
> Cc: davem@...emloft.net; Allan, Bruce W; netdev@...r.kernel.org;
> gospo@...hat.com; sassmann@...hat.com
> Subject: Re: [net-next 2/8] e1000e: initial support for i217
> 
> Jeff Kirsher <jeffrey.t.kirsher@...el.com> writes:
> 
> > diff --git a/drivers/net/ethernet/intel/e1000e/defines.h
> b/drivers/net/ethernet/intel/e1000e/defines.h
> > index 3a50259..11c4666 100644
> > --- a/drivers/net/ethernet/intel/e1000e/defines.h
> > +++ b/drivers/net/ethernet/intel/e1000e/defines.h
> > @@ -74,7 +74,9 @@
> >  #define E1000_WUS_BC           E1000_WUFC_BC
> >
> >  /* Extended Device Control */
> > +#define E1000_CTRL_EXT_LPCD  0x00000004     /* LCD Power Cycle Done
> */
> >  #define E1000_CTRL_EXT_SDP3_DATA 0x00000080 /* Value of SW
> Definable Pin 3 */
> > +#define E1000_CTRL_EXT_FORCE_SMBUS 0x00000004 /* Force SMBus mode*/
> >  #define E1000_CTRL_EXT_EE_RST    0x00002000 /* Reinitialize from
> EEPROM */
> >  #define E1000_CTRL_EXT_SPD_BYPS  0x00008000 /* Speed Select Bypass
> */
> >  #define E1000_CTRL_EXT_RO_DIS    0x00020000 /* Relaxed Ordering
> disable */
> 
> The mangled sorting and alignment of the new entries made me wonder if
> this was a typo.  But reading further below it looks like
> E1000_CTRL_EXT_LPCD is input and E1000_CTRL_EXT_FORCE_SMBUS is output.
> If that is correct, then it probably deserves a small comment here
> along
> with better sorting and alignment to make it clear that the duplicate
> value is intentional?
> 
> 
> Bjørn

It is a typo.  An updated patch will follow soon.

Thanks for spotting that,
Bruce.