netdev - Re: [PATCH] netlink: connector: implement cn_netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1336677745.2874.18.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 10 May 2012 20:22:25 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Alban Crequy <alban.crequy@...labora.co.uk>
CC:	Evgeniy Polyakov <zbr@...emap.net>, <netdev@...r.kernel.org>,
	Vincent Sanders <vincent.sanders@...labora.co.uk>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Rodrigo Moya <rodrigo.moya@...labora.co.uk>
Subject: Re: [PATCH] netlink: connector: implement cn_netlink_reply

On Thu, 2012-05-10 at 11:39 +0100, Alban Crequy wrote:
> On Thu, 10 May 2012 04:45:53 +0400,
> Evgeniy Polyakov <zbr@...emap.net> wrote :
> 
> > On Thu, May 10, 2012 at 01:20:48AM +0100, Ben Hutchings
> > (bhutchings@...arflare.com) wrote:
> > > On Wed, 2012-05-09 at 15:37 +0100, Alban Crequy wrote:
> > > > In a connector callback, it was not possible to reply to a
> > > > message only to a sender. This patch implements
> > > > cn_netlink_reply(). It uses the connector socket to send an
> > > > unicast netlink message back to the sender.
> > > [...]
> > > 
> > > We try to avoid adding functions with no users.  You'll need to
> > > submit the code that's intended to use this as well.
> > 
> > I have no objection against this patch, but as correctly stated it is
> > useless without users. Alban, what is the code you want this
> > functionality to be used in? Do you plan to submit it? Can you submit
> > this change in the patch with your code?
> 
> The code to use the feature is not yet ready for submission and we will
> add this patch to the front of that submission in due course.
> 
> We are just being good community members and making each patch
> available early.

When you send a message with a subject beginning [PATCH] to a kernel
mailing list, it's generally assumed to be a request to the relevant
maintainer to apply that patch.  But kernel API functions are added only
to support features that are exposed exernally, and tend to be removed
when there are no in-tree users.

You could of course send such patches as RFCs ([RFC][PATCH] in the
subject), so it's clear that you don't expect them to be applied yet.

Ben.

> Thanks for your feedback on this patch. Please let
> me know if I can add any reviewed-by.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html