lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 May 2012 01:18:10 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Stephen Hemminger <shemminger@...tta.com> CC: Catherine Sullivan <catherine.sullivan@...el.com>, <netdev@...r.kernel.org> Subject: Re: [NET_NEXT RFC PATCH 3/3] ixgbe: added reg_ops file to debugfs On Wed, 2012-05-09 at 16:14 -0700, Stephen Hemminger wrote: > On Wed, 09 May 2012 16:09:50 -0700 > Catherine Sullivan <catherine.sullivan@...el.com> wrote: > > > Added the reg_ops file to debugfs with commands to read and write > > a register to give users the ability to read and write individual > > registers on the fly. > > > > Signed-off-by: Catherine Sullivan <catherine.sullivan@...el.com> > > --- > > > > drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 112 ++++++++++++++++++++++ > > 1 files changed, 112 insertions(+), 0 deletions(-) > > > > Aren't these registers already in ethtool? ethtool register access is read-only and would be very heavy-weight for interactive debugging. Not sure this is the best interface to read/write registers, but it's certainly not redundant. > You are also allowing write without any security checking. The file permissions are set to 0600 so it's root-only. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists