netdev - Re: [B.A.T.M.A.N.] [PATCH 07/14] batman-adv: split neigh_new function into generic and batman iv specific parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 May 2012 14:08:07 +0800
From:	Marek Lindner <lindner_marek@...oo.de>
To:	b.a.t.m.a.n@...ts.open-mesh.org
Cc:	David Miller <davem@...emloft.net>, ordex@...istici.org,
	netdev@...r.kernel.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 07/14] batman-adv: split neigh_new function into generic and batman iv specific parts


David,

> But once it gets exported out of that file, you have to give it
> an appropriate name.  Probably with a "batman_adv_" prefix or
> similar.
> 
> Otherwise, for one thing, if this code is statically built into
> the tree it can conflict with symbol names elsewhere and break
> the build.

thanks for pointing this out. I wasn't aware of the potential conflict created 
by our naming scheme. Obviously, we will change the proposed patch.
We are going to review all other exported function names and send appropriate 
patches later on.

Regards,
Marek
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html