netdev - Re: [PATCH 07/14] batman-adv: split neigh_new function into generic and batman iv specific parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120509.204111.1931607501484626500.davem@davemloft.net>
Date:	Wed, 09 May 2012 20:41:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ordex@...istici.org
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	lindner_marek@...oo.de
Subject: Re: [PATCH 07/14] batman-adv: split neigh_new function into
 generic and batman iv specific parts

From: Antonio Quartulli <ordex@...istici.org>
Date: Wed,  9 May 2012 13:12:49 +0200

> From: Marek Lindner <lindner_marek@...oo.de>
> 
> Signed-off-by: Marek Lindner <lindner_marek@...oo.de>
> Acked-by: Simon Wunderlich <siwu@....tu-chemnitz.de>
> Signed-off-by: Antonio Quartulli <ordex@...istici.org>

The namespace pollution of the batman-adv code needs to improve,
and I'm putting my foot down starting with this change.

If you have a static function which is therefore private to a
source file, name it whatever you want.

But once it gets exported out of that file, you have to give it
an appropriate name.  Probably with a "batman_adv_" prefix or
similar.

Otherwise, for one thing, if this code is statically built into
the tree it can conflict with symbol names elsewhere and break
the build.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html