netdev - Re: [PATCH v2 4/5] net: sh_eth: add support for set_ringparam/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 May 2012 16:27:10 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com>
CC:	netdev <netdev@...r.kernel.org>,
	SH-Linux <linux-sh@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] net: sh_eth: add support for
 set_ringparam/get_ringparam

On Fri, 2012-05-11 at 17:38 +0900, Shimoda, Yoshihiro wrote:
> This patch supports the ethtool's set_ringparam() and get_ringparam().
[...]
> +static int sh_eth_set_ringparam(struct net_device *ndev,
> +				struct ethtool_ringparam *ring)
> +{
> +	struct sh_eth_private *mdp = netdev_priv(ndev);
> +	int ringsize;
> +
> +	if (ring->tx_pending > TX_RING_MAX ||
> +	    ring->rx_pending > RX_RING_MAX ||
> +	    ring->tx_pending < TX_RING_MIN ||
> +	    ring->rx_pending < RX_RING_MIN)
> +		return -EINVAL;
> +	if (ring->rx_mini_pending || ring->rx_jumbo_pending)
> +		return -EINVAL;
> +
> +	if (netif_running(ndev)) {
> +		/* Disable interrupts by clearing the interrupt mask. */
> +		sh_eth_write(ndev, 0x0000, EESIPR);
> +		/* Stop the chip's Tx and Rx processes. */
> +		sh_eth_write(ndev, 0, EDTRR);
> +		sh_eth_write(ndev, 0, EDRRR);

You'll also need to call netif_tx_disable() and synchronize_irq().

> +	}
> +
> +	/* Free all the skbuffs in the Rx queue. */
> +	sh_eth_ring_free(ndev);
> +	/* Free DMA buffer */
> +	ringsize = sizeof(struct sh_eth_rxdesc) * mdp->num_rx_ring;
> +	dma_free_coherent(NULL, ringsize, mdp->rx_ring, mdp->rx_desc_dma);
> +	ringsize = sizeof(struct sh_eth_txdesc) * mdp->num_tx_ring;
> +	dma_free_coherent(NULL, ringsize, mdp->tx_ring, mdp->tx_desc_dma);
> +
> +	/* Set new parameters */
> +	mdp->num_rx_ring = ring->rx_pending;
> +	mdp->num_tx_ring = ring->tx_pending;
> +
> +	sh_eth_ring_init(ndev);
> +	sh_eth_dev_init(ndev);

And what if either of these fails?

> +	if (netif_running(ndev)) {
> +		sh_eth_write(ndev, mdp->cd->eesipr_value, EESIPR);
> +		/* Setting the Rx mode will start the Rx process. */
> +		sh_eth_write(ndev, EDRRR_R, EDRRR);

You'll need to call netif_wake_queue().

> +	}
> +
> +	return 0;
> +}
[...]

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html