netdev - Re: [net-next v2 0/2][pull request] Intel Wired LAN Driver Updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120512.152750.1001784663174919311.davem@davemloft.net>
Date:	Sat, 12 May 2012 15:27:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next v2 0/2][pull request] Intel Wired LAN Driver Updates

From: David Miller <davem@...emloft.net>
Date: Sat, 12 May 2012 15:22:59 -0400 (EDT)

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Sat, 12 May 2012 02:11:56 -0700
> 
>> This series of patches contains updates for igb.  Most notably,
>> the addition of i210 & i211 support.
>> 
>> v2: fix up patch 2 based on feedback from David Miller
>> 
>> The following are changes since commit 06a4c1c55dbe5d9f7a708e8f1a52fd2ac8e5874f:
>>   6lowpan: IPv6 link local address
>> and are available in the git repository at:
>>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> Pulled, thanks.

Actually, I unpulled.

These changes introduce a new compiler warning because mrqc is now
only set conditionally and the code is such that the compiler cannot
see whether or not mrqc is only used when it is in fact set.

Please re-arrange the code so that this warning will not occur.

drivers/net/ethernet/intel/igb/igb_main.c: In function ‘igb_configure’:
drivers/net/ethernet/intel/igb/igb_main.c:2903:7: warning: ‘mrqc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/ethernet/intel/igb/igb_main.c:2806:6: note: ‘mrqc’ was declared here