netdev - Re: [net-next 2/2] stmmac: add mixed burst for DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FB0B2AC.5070903@st.com>
Date:	Mon, 14 May 2012 09:22:20 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next 2/2] stmmac: add mixed burst for DMA

On 5/12/2012 12:12 AM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
> Date: Mon,  7 May 2012 11:12:33 +0200
> 
>> -	int (*init) (void __iomem *ioaddr, int pbl, int fb, int burst_len,
>> -			u32 dma_tx, u32 dma_rx);
>> +	int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb,
>> +			int burst_len, u32 dma_tx, u32 dma_rx);
> 
> Fix the indentation of the arguments on the second line,
> the first character must line up with the first column after
> the function's openning parenthesis on the previous line.

Yes, my fault and fixed at once.

> 
>> -static int dwmac1000_dma_init(void __iomem *ioaddr, int pbl, int fb,
>> +static int dwmac1000_dma_init(void __iomem *ioaddr, int pbl, int fb, int mb,
>>  			      int burst_len, u32 dma_tx, u32 dma_rx)
> 
> While you're here fix up that issue in the existing code here as well.
> 
>> -static int dwmac100_dma_init(void __iomem *ioaddr, int pbl, int fb,
>> +static int dwmac100_dma_init(void __iomem *ioaddr, int pbl, int fb, int mb,
>>  			     int burst_len, u32 dma_tx, u32 dma_rx)
> 
> Likewise.

After applying the patch the argument "int burst_len" is aligned with
the first column after the opening parenthesis.
Anyway I've just re-looked at the code and verified that.

> 
>> -	int pbl = DEFAULT_DMA_PBL, fixed_burst = 0, burst_len = 0;
>> +	int pbl = DEFAULT_DMA_PBL, fixed_burst = 0, burst_len = 0,
>> +	    mixed_burst = 0;
> 
> This is gross, just make a new "int" declaration for mixed_burst.

fixed :-(

I'm resending the patches now.

Thanks for your review and sorry for these kind of errors.

peppe

> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html