netdev - RE: [PATCH 2/6] netfilter: decnet: switch hook PFs to nfproto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6F0A@saturn3.aculab.com>
Date:	Mon, 14 May 2012 15:18:16 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Alban Crequy" <alban.crequy@...labora.co.uk>,
	"Pablo Neira Ayuso" <pablo@...filter.org>,
	"Patrick McHardy" <kaber@...sh.net>
Cc:	"Vincent Sanders" <vincent.sanders@...labora.co.uk>,
	"Javier Martinez Canillas" <javier.martinez@...labora.co.uk>,
	<netfilter-devel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: RE: [PATCH 2/6] netfilter: decnet: switch hook PFs to nfproto

 
> NFPROTO_* constants were usually equal to PF_* constants but it is not
> necessary and it will waste less memory if we don't do so 
> (see commit 7e9c6e
> "netfilter: Introduce NFPROTO_* constants")
...
>  
>  static struct nf_hook_ops dnrmg_ops __read_mostly = {
>  	.hook		= dnrmg_hook,
> -	.pf		= PF_DECnet,
> +	.pf		= NFPROTO_DECNET,
>  	.hooknum	= NF_DN_ROUTE,
>  	.priority	= NF_DN_PRI_DNRTMSG,
>  };

Might it be worth renaming the .pf member to (say) .nfproto
to help avoid confusion?

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html