netdev - Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120515.015916.1228365475475285173.davem@davemloft.net>
Date:	Tue, 15 May 2012 01:59:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set
 but not used variables

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue, 15 May 2012 08:52:06 +0300

> On 5/15/2012 7:07 AM, David Miller wrote:
>>
>>> -		err = mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>>> + (void) mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>>>   					    rgid->steer);
>>
>> You must update the indentation of all the lines comprising of the
>> function call when you change the indentation of it's initial line.
> 
> Just want to make sure I understood right what has to be done here,
> e.g in this case its needs to be
> like this?
 ...
>> -                                           rgid->steer);
>> + (void) mlx4_qp_detach_common(dev, &qp, rgid->gid, rgid->prot,
>> +                                                   rgid->steer);

I can't tell if it's right, becuase it got all reformatted by your
mail client.

You simply need to make sure the arguments on the second and
further lines line up with the column after the openning
parenthesis on the first line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html